-
Notifications
You must be signed in to change notification settings - Fork 5
ENH: Add emailer for fixed line testing affected flavors #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Draft until I add unit tests |
154bc51
to
bcc736b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #389 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 105 107 +2
Lines 2468 2568 +100
Branches 356 393 +37
==========================================
+ Hits 2468 2568 +100 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1cfe68e
to
bad3699
Compare
bad3699
to
67f330f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tempted to close this and reopen if we need it later
Shall we just merge to get the code in? The action won't run unless people run it. I add the print_email func in this PR too, which would be nice-to-have for other actions I can always split that off though |
maybe set the action to enabled: false - so people won't use it |
So we can still merge the code incase it's useful in future Don't wanna leave code on a branch that could be deleted
Done |
Description:
Note: Dates are hard-coded, while flavors are customisable.
This is because:
Also adds a helper "Print Email" debug function to the emailer
Special Notes:
Submitter:
Have you (where applicable):
Reviewer
Does this PR:
lib
directory?lib
layers?